Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenAI Organization ID header #27

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add support for OpenAI Organization ID header #27

merged 1 commit into from
Mar 1, 2024

Conversation

AshDevFr
Copy link
Contributor

This PR is to address the issue #26.

I used optional arguments to make sure the change does not introduce any breaking changes to the library (in theory).

Let me know if that works for you.

tazarov
tazarov previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you @AshDevFr

@tazarov
Copy link
Contributor

tazarov commented Mar 1, 2024

@AshDevFr, linter is complaining:

run golangci-lint
  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: ST1003: struct field OrgId should be OrgID (stylecheck)
  Error: ST1003: method SetOrgId should be SetOrgID (stylecheck)
  Error: ST1003: func WithOpenAIOrganizationId should be WithOpenAIOrganizationID (stylecheck)

Do you mind updating these?

@AshDevFr
Copy link
Contributor Author

AshDevFr commented Mar 1, 2024

I'll update, sorry about that, I forgot to check the linter 🤦🏻‍♂️

@tazarov tazarov merged commit 00bb033 into amikos-tech:main Mar 1, 2024
1 of 3 checks passed
@AshDevFr AshDevFr mentioned this pull request Mar 4, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tazarov tazarov tazarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshDevFr @tazarov