-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit on bad geometry #256
base: master
Are you sure you want to change the base?
exit on bad geometry #256
Conversation
when geometry argument received is invalid, prevent wf-recorder from recording rather than setting geometry to 0,0 0x0
Maybe have the output message suggest that the geometry might need to be in quotation marks, too? |
That is already mentioned in the documentation as well as '--help' text. Adding something like 'see: wf-recorder --help' to the message should suffice. |
Maybe |
Well, we can't simply assume that the value is wrong only because it is not properly quoted. Maybe the user has given a completely wrong data that doesn't represent any geometry. |
The reason I suggest the message suggestion is because 1) the number one reason this happens is because people forget the quotations and 2) a message telling people to look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @soreau, it would be nice to directly print an example of how to set the geometry and say it should be quoted.
When geometry argument received is invalid, prevent wf-recorder from recording rather than setting geometry to default '0,0 0x0' and continue recording.