Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #48: Bugs with Mentions and with Queue Length History from Regex Update #49

Merged
merged 2 commits into from
May 25, 2021

Conversation

amthorn
Copy link
Owner

@amthorn amthorn commented May 25, 2021

This PR Fixes a bug raised in issue #48 where the recent regex update broke some command parsers. This PR also adds several pieces of missing parse coverage to ensure this won't happen again.

Resolves #48

@amthorn amthorn added the bug Something isn't working label May 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #49 (69dc81a) into master (1cfdbab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines          915       920    +5     
  Branches       122       123    +1     
=========================================
+ Hits           915       920    +5     
Impacted Files Coverage Δ
services/bot/src/commands/admins/create.ts 100.00% <100.00%> (ø)
services/bot/src/commands/admins/remove.ts 100.00% <100.00%> (ø)
...ices/bot/src/commands/graphs/queueLengthHistory.ts 100.00% <100.00%> (ø)
services/bot/src/commands/queue/addPerson.ts 100.00% <100.00%> (ø)
services/bot/src/commands/queue/get.ts 100.00% <100.00%> (ø)
services/bot/src/commands/queue/removePerson.ts 100.00% <100.00%> (ø)
services/bot/src/parser.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfdbab...69dc81a. Read the comment docs.

@amthorn amthorn merged commit a3efa33 into master May 25, 2021
@amthorn amthorn deleted the feature/issue-48 branch May 25, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating admins and getting queue length history are erroring
2 participants