Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Flip strong vs weak pull-up bit values #1145

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

Jake-Carter
Copy link
Contributor

Description

Apparently most UGs have this flipped. Strong should set the ps field to 0, while weak should set it to 1.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@Jake-Carter
Copy link
Contributor Author

Pending final confirmation... don't merge yet

@github-actions github-actions bot added MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) MAX32572 Related to the MAX32572 (ME55) labels Aug 29, 2024
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this unnoticed for so long lol

@perkinsmg
Copy link
Contributor

There are lots of instances where we use the enums which will now have the opposite effect to what they did before.
Mostly that's probably good, because they were probably not working correctly before.
But in at least the case of the MXC_GPIO_PAD_PULL_UP used in pins_me18.c for the UART signals, Kevin's check-in message said he was adding a weak pull-up, and Lorne recommends a weak pull-up, so I think we should change these to weak to preserve the old behaviour.

@Jake-Carter
Copy link
Contributor Author

There are lots of instances where we use the enums which will now have the opposite effect to what they did before. Mostly that's probably good, because they were probably not working correctly before. But in at least the case of the MXC_GPIO_PAD_PULL_UP used in pins_me18.c for the UART signals, Kevin's check-in message said he was adding a weak pull-up, and Lorne recommends a weak pull-up, so I think we should change these to weak to preserve the old behaviour.

@perkinsmg updated in 1717e1a

@Jake-Carter Jake-Carter merged commit a5cc8d5 into analogdevicesinc:main Sep 4, 2024
8 checks passed
@Jake-Carter Jake-Carter deleted the fix/gpio-pullups branch September 4, 2024 20:05
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 4, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
ttmut pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32572 Related to the MAX32572 (ME55) MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants