-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PeriphDrivers): Flip strong vs weak pull-up bit values #1145
fix(PeriphDrivers): Flip strong vs weak pull-up bit values #1145
Conversation
Pending final confirmation... don't merge yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this unnoticed for so long lol
There are lots of instances where we use the enums which will now have the opposite effect to what they did before. |
@perkinsmg updated in 1717e1a |
Description
Apparently most UGs have this flipped. Strong should set the
ps
field to 0, while weak should set it to1
.Checklist Before Requesting Review