Fix AI85/AI87 Image Capture Examples (ImgCapture, CSI2) #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Determine root cause (CSI2 hardware again? Settings? Drivers?)
TODO: Determine root cause (CSI2 hardware again? Settings? Drivers?)
|
/clang-format-run |
Jacob-Scheiffler
approved these changes
Feb 14, 2023
Examples/MAX78002/CSI2/main.c
Outdated
| @@ -195,7 +210,7 @@ void service_console() | |||
| clear_serial_buffer(); | |||
| } | |||
|
|
|||
| volatile int buttonPressed = 0; | |||
There was a problem hiding this comment.
Be careful taking out the volatile, may cause example to hang if compiler optimization level is increased.
There was a problem hiding this comment.
Thanks, good catch
sihyung-maxim
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #283 UART writes became non-blocking, which broke the serial console used by ImgCapture and CSI2 on the AI85/AI87.
This PR re-introduces a blocking write function into the example's local source code until a long-term solution in #285 is implemented.
It also applies a temporary workaround to some newly discovered CSI2 issues to get captures working reliably again. (CSI2 output buffer memory contention, see AI87-123, AI87-129).
These are fundamental fixes that must be released in the next MSDK version, but also contain the foundations for longer-term solutions that will be released by the grace of the microcontroller gods.
Related Jira: MSDK-917