Dev me12 fthr support #469
Conversation
| if ((error = MXC_UART_Init(WRITING_UART, UART_BAUD, MXC_UART_APB_CLK, MAP_A)) != E_NO_ERROR) { | ||
| #else | ||
| if ((error = MXC_UART_Init(WRITING_UART, UART_BAUD, MXC_UART_APB_CLK, MAP_B)) != E_NO_ERROR) { |
There was a problem hiding this comment.
#if else condition seems not needed.
The function and parameters are exactly same.
There was a problem hiding this comment.
if calls MAP_A else calls MAB_B. They are not exactly same.
There was a problem hiding this comment.
The UART0B pins are accessible on the EvKit (RX: P0.7; TX: P0.8). Would it be easier if both the EvKit and FTHR boards use UART0B as the WRITING_UART and UART1A as the READING_UART? Unless you want to show the MAP_A vs MAP_B difference, this will minimize the amount of #if,#else,#endif directives used between the two boards if both run on the same set of pins.
Examples/MAX32662/UART/main.c
Outdated
| if ((error = MXC_UART_Init(READING_UART, UART_BAUD, MXC_UART_APB_CLK, MAP_A)) != E_NO_ERROR) { | ||
| #else | ||
| if ((error = MXC_UART_Init(READING_UART, UART_BAUD, MXC_UART_APB_CLK, MAP_A)) != E_NO_ERROR) { |
There was a problem hiding this comment.
#if else condition seems not needed.
The function and parameters are exactly same.
To simplify code it should be deleted.
|
|
||
| #include <stdio.h> | ||
|
|
||
| #ifndef LIBRARIES_BOARDS_MAX32662_EVKIT_V1_INCLUDE_BOARD_H_ |
There was a problem hiding this comment.
Using FTHR would be better instead of EVKIT_V1
| ARM-DSP/arm_sin_cos_example | ||
| ARM-DSP/arm_svm_example | ||
| ARM-DSP/arm_variance_example | ||
| Bootloader_Host |
There was a problem hiding this comment.
Please remove
- Bootloader_Host
- EEPROM_Emulator
- I2C_Manager (if you validated it is ok)
There was a problem hiding this comment.
done 5ce180a
Note : I2C_Manager is skipped. Please check confluence.
karaanil
force-pushed
the
dev-me12-fthr-support
branch
from
da0dea6 to
1a9774e
Compare
There was a problem hiding this comment.
UART Example:
The UART0B pins are accessible on the EvKit (RX: P0.7; TX: P0.8). Would it be easier if both the EvKit and FTHR boards use UART0B as the WRITING_UART and UART1A as the READING_UART? Unless you want to show the MAP_A vs MAP_B difference, this will minimize the amount of #if,#else,#endif directives used between the two boards if both run on the same set of pins.
karaanil
force-pushed
the
dev-me12-fthr-support
branch
from
1a9774e to
b8eee90
Compare
|
@sihyung-maxim UART example is done 5ce180a |
karaanil
force-pushed
the
dev-me12-fthr-support
branch
from
b8eee90 to
5ce180a
Compare
|
@sihyung-maxim could you merge it? |
No description provided.