fix(workflow): Make pull_request_template.md visible and update trigger-types for auto-labeler workflow #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihyung-maxim
requested review from
Jake-Carter,
EdwinFairchild and
Jacob-Scheiffler
EdwinFairchild
approved these changes
Jul 3, 2023
.github/workflows/labeler.yml
Outdated
| # Controls when the workflow will run | ||
| on: | ||
| pull_request_target: | ||
| types: [opened, edited, reopened] | ||
| types: [opened, edited, reopened, synchronize, converted_to_draft, readu_for_review, assigned, review_requested] |
There was a problem hiding this comment.
oops, good catch
Jacob-Scheiffler
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Documentation" folder is not a valid directory to place the pull_request_template.md (Docs is valid though). I moved the template into
.github/, and hopefully, it does not override the README.md in the repo's root.I also added more trigger types for the auto-labeler to run and removed the concurrency because it's a lightweight action that runs from Github's Ubuntu servers. (And in case the workflow gets cancelled because we have a lot of actions running for a PR now).