Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BLE): Feat to allow advertising updates while advertising #734

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

EdwinFairchild
Copy link
Contributor

@EdwinFairchild EdwinFairchild commented Sep 18, 2023

Description

(nothing critical here that needs to be merged before September release)
Allows the update of advertising data on the fly, per use case of customers, and the project our interns worked on.
Low leve function that does the ultimate updating is protected in critical section guards so I do not see updating on the fly as an issue, Nordics SDK does the same.

TODO

I will write some documentation (separate PR) on this to the user guide since updating on the fly needs a specific workflow.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@EdwinFairchild EdwinFairchild added the WIP work in progress label Sep 18, 2023
@EdwinFairchild EdwinFairchild changed the title fix(BLE): feat to allow advertising updates while advertising fix(BLE): Feat to allow advertising updates while advertising Sep 18, 2023
@github-actions github-actions bot added the BLE Related to Bluetooth label Sep 18, 2023
@EdwinFairchild EdwinFairchild merged commit 0d5163a into main Oct 24, 2023
@EdwinFairchild EdwinFairchild deleted the update-advertising branch October 24, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Related to Bluetooth WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants