feat(Examples): Add Ref Trim procedure to MAX32690 ADC Example #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrentK-ADI
force-pushed
the
max32690_adc_trim
branch
from
8a3fb27 to
cf70915
Compare
|
Force push to cf70915 was to resolve cpplint and clang-format errors. |
sihyung-maxim
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Looks good. Maybe add a small comment to the functions saying the trim procedure is from the user guide?
Ideally, people will reference the user guide when they see the trim procedure in the example, but I can see folks will ask where the magic numbers (0x0C,0x0D,0xF0,etc) are from without checking the user guide.
BrentK-ADI
force-pushed
the
max32690_adc_trim
branch
from
cf70915 to
c1f9ea7
Compare
|
Added comments to trim functions calling out the UG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(Examples): Add Ref Trim procedure to MAX32690 ADC Example
Description
Adds functions to the MAX32690 ADC example project to perform the reference trim for all ADC reference sources.
Checklist Before Requesting Review