Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CMSIS): Fix MAX32690 SRAM Size Calculation #843

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Dec 20, 2023

Pull Request Template

Description

Total SRAM size shall be 1MB.
In linker file SRAM size calculated by below formula ARM_SRAM_SIZE = _SRAM_SIZE - _RISCV_SRAM_SIZE;
ARM SRAM size shall be less than total incase of riscv core enabled.

This condition causes issue while working on DAPLink fw for MAX32690.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

image

image

In linker file SRAM size calculated by below formula
ARM_SRAM_SIZE = _SRAM_SIZE - _RISCV_SRAM_SIZE;
Total SRAM size is 1MB (0x100000) not 0x120000.
ARM SRAM size shall be less than total incase of riscv core enabled.

Signed-off-by: Sadik Ozer <[email protected]>
@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Dec 20, 2023
@sihyung-maxim sihyung-maxim changed the title fix(CMSIS): MAX32690 total SRAM size is 1MB fix(CMSIS): Fix MAX32690 total SRAM size to 1MB Dec 20, 2023
@Jake-Carter Jake-Carter changed the title fix(CMSIS): Fix MAX32690 total SRAM size to 1MB fix(CMSIS): Fix MAX32690 SRAM Size Calculation Dec 21, 2023
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozersa

@Jake-Carter Jake-Carter merged commit 02a8761 into main Dec 21, 2023
14 checks passed
@Jake-Carter Jake-Carter deleted the fix/max32690_sram_size branch December 21, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants