fix(PeriphDrivers): Add I2C RX FIFO status check to receive more than 256-byte of data for I2C synchronous transactions #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetalincak
changed the title
alperenguclu
approved these changes
Jan 12, 2024
sihyung-maxim
changed the title
sihyung-maxim
approved these changes
Jan 12, 2024
Jake-Carter
approved these changes
Jan 13, 2024
Jake-Carter
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Thanks @alperenguclu - it looks like this works around some FIFO issue at the end of each 256-byte chunk, is that right?
Any details you can share on the hardware issue may be helpful at some point in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@alperenguclu faced a problem while trying to receive more than 256-byte data from I2C channel and we found that
MXC_I2C_RevA_MasterTransactionhas a bug in rx part. His team tested it with MAX32690.