Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Boards,MAXUSB,MiscDrivers,PeriphDrivers): Fix most IAR build errors and warnings for MAX32690 #899

Merged
merged 10 commits into from
Feb 1, 2024

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Jan 31, 2024

Description

This PR fixes all build errors and most build warnings. The remaining build warnings are: 1) linker file/flash loader related between IAR and GCC in the SEMA PeriphDrivers, and 2) not explicitly defining the order of volatile access.

The purpose of this PR is to prep the MAX32690 for the IAR new project package.

These changes are compatible with GCC as most warnings are due to unreachable blocks that GCC doesn't catch, or IAR's sensitivity to casts.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Jan 31, 2024
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@github-actions github-actions bot added the MAX32672 Related to the MAX32672 (ME21) label Feb 1, 2024
@sihyung-maxim sihyung-maxim merged commit f95916a into main Feb 1, 2024
9 checks passed
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
… errors and most warnings for MAX32690 (#899)"

This reverts commit f95916a.
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
…AR build errors and most warnings for MAX32690 (#899)""

This reverts commit f739155.
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
…): Fix IAR build errors and most warnings for MAX32690 (#899)"""

This reverts commit c040f78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32672 Related to the MAX32672 (ME21) MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants