Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Fix Unusable MAX32690 I2C Pins #958

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

Jake-Carter
Copy link
Contributor

Pull Request Template

Description

Fixes #949

The ME18 assigns the same alternate function to both sets of I2C pins. This is logged as an errata (Rev A2 Errata 16), but in order to make the second set of pins usable our drivers will now configure both sets simultaneously.

Doxygen has been updated on the init function to highlight this change:

image

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Mar 19, 2024
Copy link
Contributor

@BrentK-ADI BrentK-ADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the wrong pins for I2C2C. I believe it is P0.13/P0.14

I was only able to test I2C0 due to the pin outs of the APARD board. I2C1 (P0.11/12) has pull downs and I2C2C (P1.7/8) are used as CTS/RTS for the NINA module. If someone has a generic 140WLP board to test those on, it would be helpful.

Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the MSDK version stuff reverting to the last release.

@Jake-Carter
Copy link
Contributor Author

Not sure about the MSDK version stuff reverting to the last release.

@sihyung-maxim need to merge #954

@Jake-Carter Jake-Carter merged commit 7db1d20 into analogdevicesinc:main Mar 21, 2024
7 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-949 branch March 21, 2024 00:42
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX32690/ME18 Alternate I2C
3 participants