Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Fix error returned when closing VoiceClient #301

Merged
merged 1 commit into from
May 31, 2020

Conversation

oidq
Copy link
Contributor

@oidq oidq commented May 31, 2020

Description

Modify nhooyr/websocket Read wrapper to handle disconnect after context being cancelled (coder/websocket#242)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I ran go generate
  • I have performed a self-review of my own code (remember to run go fmt ./...)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Added benchmarks if this is a performant required component (potential bottlenecks)

* fix handling of error in nhooyr websocket wrapper (mentioned in andersfylling#298)
	* closing context given to g.c.Read(ctx) leads to WebSocket being closed
  	  coder/websocket#242
@andersfylling andersfylling merged commit 8da3c4e into andersfylling:develop May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants