feat(core): add source to StaticInjectorError message
#20817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
area: core
3 tasks
|
You can preview 2b12e7f at https://pr20817-2b12e7f.ngbuilds.io/. |
|
Was rolled back in g3. Determine cause before merging. |
mhevery
suggested changes
Dec 6, 2017
| @@ -25,7 +25,7 @@ export function moduleProvideDef( | |||
| // lowered the expression and then stopped evaluating it, | |||
| // i.e. also didn't unwrap it. | |||
| value = resolveForwardRef(value); | |||
| const depDefs = splitDepsDsl(deps); | |||
There was a problem hiding this comment.
The issue is that token can be null
There was a problem hiding this comment.
You should use stringify from core/src/util here as stringify(token)
mhevery
reviewed
Dec 6, 2017
packages/core/src/view/provider.ts
Outdated
| @@ -83,7 +83,7 @@ export function _def( | |||
| // i.e. also didn't unwrap it. | |||
| value = resolveForwardRef(value); | |||
|
|
|||
| const depDefs = splitDepsDsl(deps); | |||
| const depDefs = splitDepsDsl(deps, token.name); | |||
ocombe
force-pushed
the
feat/static-injector
branch
from
2b12e7f to
032789a
Compare
|
You can preview 032789a at https://pr20817-032789a.ngbuilds.io/. |
mhevery
approved these changes
Dec 12, 2017
mhevery
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We need more info on
StaticInjectorErrorto help with debuggingIssue Number: #19302, also Fixes #20172
What is the new behavior?
We add the source component (or module) that tried to inject the missing provider, and we also add the source from the injector which triggered the error
Notes:
__source, we could use a different property name (I wasn't inspired), but I'm not sure if it's ok to add a property name like that.Does this PR introduce a breaking change?
Other information
I already did a PR with that change but we had to revert because of issues in g3, but I don't know what were the issues, and I haven't changed the code since then.