-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document guidelines for every field #255
Conversation
That's really clear and thorough, while still being maximally concise! Should the case of duplicate country names (#212) — currently only Saint-Martin/Sint Maarten in French and Spanish be mentioned or is it too much of a tiny corner-case? (I can't really think of any other potential omissions.) |
Shouldn't this:
be at the end of line 65, giving something like:
|
Woops, thanks! I simplified the paragraph a little (I think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scraped the bottom of the barrel in terms of review comments 😅 Looks good 👍
With all the discussions that took place over the past few months, I thought it wise to add to the content guidelines for each field in CONTRIBUTING.md.
I wrote as much as I could, trying to remember all the decisions that we've made so far. I'm sure I've made a lot of mistakes and forgot some things. Please pick them apart 🔍 and don't hesitate to crush my feelings if you think something could be better written! ❤️
There's probably a bit of work to be done to apply these guidelines consistently in the deck (notably for capitals), and they'll probably have to be adjusted as we go. I'm still not a huge fan of having multiple capitals in the Capital field, so I'm down with any guideline we can write to avoid that... 😂