Fix 'NoneType object is not subscriptable' error #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes TypeError 'NoneType' object is not subscriptable
If the key is not in the dictionary, we want to raise a KeyError rather than returning None. That way, we can distinguish between whether the value was None or the key was not found.
…object-is-not-subscriptable Merged to include 88b5064 to fix pipeline.
|
Is this an error you were seeing in the wild? |
|
No, my intention was to fix the type errors that Pyright reports. Since I use type checkers and linters quite extensively, I'd like them to be happy with the code so that the critical problems can't go unnoticed. After some more research, it seems that when you download an add-on from I now realize the safeguard I implemented is useful only if any of these four keys |
davidculley
deleted the
feature/fix-nonetype-object-is-not-subscriptable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't access the first item of a list if you happen to get
Noneinstead of a list.This pull request fixes a
by ensuring the returned value is indeed a list and not
None.