-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments for translators about sort order #3831
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making things easier for the translators! Please see CONTRIBUTORS for how you can get the tests to pass, so I can merge this in.
Some minor constructive feedback for future PRs: there's a fair bit of repetition in these comments. The combobox and 'sort the cards by' prefixes could have been moved into a ## section comment
for example.
As a hint: If you click on the
I checked your files with Not sure why this happens though, as you have two entries in CONTRIBUTORS:
And the first one clearly is a gmail.com email. Maybe the second entry overwrote that. Is that possible? |
Done.
Moved "Combobox" string to ## comment, creating an own group for the combobox entries. Keeping 'sort the cards by' in the # comment to avoid a word puzzle between ## and # comments. |
Rewording otherwise done. |
Removed one of them. Check passes now. |
No string changes.