Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments for translators about sort order #3831

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sommerluk
Copy link
Contributor

No string changes.

Copy link
Member

@dae dae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making things easier for the translators! Please see CONTRIBUTORS for how you can get the tests to pass, so I can merge this in.

Some minor constructive feedback for future PRs: there's a fair bit of repetition in these comments. The combobox and 'sort the cards by' prefixes could have been moved into a ## section comment for example.

@GithubAnon0000
Copy link
Contributor

Please see CONTRIBUTORS for how you can get the tests to pass, so I can merge this in.

As a hint: If you click on the buildkite/anki-ci link (see picture) it shows you the error. In your case the error is

Author sommerluk, at the domain gmail.com NOT found in list

Please make sure you modify the CONTRIBUTORS file using the email address you are committing from. If you have GitHub configured to hide your email address, you may need to make a change to the CONTRIBUTORS file using the GitHub UI, then try again.

I checked your files with ./ninja check – they are fine. So apart from daes suggestion there is nothing else to modify here.

anki

Not sure why this happens though, as you have two entries in CONTRIBUTORS:

Lukas Sommer [email protected]
Lukas Sommer [email protected]

And the first one clearly is a gmail.com email. Maybe the second entry overwrote that. Is that possible?

@sommerluk
Copy link
Contributor Author

Please see CONTRIBUTORS for how you can get the tests to pass, so I can merge this in.

Done.

The combobox and 'sort the cards by' prefixes could have been moved into a ## section comment for example.

Moved "Combobox" string to ## comment, creating an own group for the combobox entries. Keeping 'sort the cards by' in the # comment to avoid a word puzzle between ## and # comments.

@sommerluk
Copy link
Contributor Author

Sort order for new cards/reviews

Rewording otherwise done.

@sommerluk
Copy link
Contributor Author

Not sure why this happens though, as you have two entries in CONTRIBUTORS:

Lukas Sommer [email protected]
Lukas Sommer [email protected]

And the first one clearly is a gmail.com email. Maybe the second entry overwrote that. Is that possible?

Removed one of them. Check passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants