-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file icon #1269
Add file icon #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorchW, thanks for pointing it out. We already have an SVG located at the images
dir. Kindly update the PR to use that SVG rather than adding a new PNG.
Yes, I used that SVG file and adjusted the margins and the color slightly to fit with the other file icons in VS Code. The original icon is bigger and brighter and thus looks out-of-place. I had a look at it in both dark and light mode, and the adjusted color works for both. (I just had a look at the default dark and light themes, I didn't check every theme there is.) |
@priyamsahoo ping |
@GeorchW could you please rebase? |
@goneri done |
Thank you @GeorchW! |
|
I felt that it's a bit ugly to have no icon for Ansible files.