Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file icon #1269

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Add file icon #1269

merged 2 commits into from
Jul 30, 2024

Conversation

GeorchW
Copy link
Contributor

@GeorchW GeorchW commented Apr 23, 2024

I felt that it's a bit ugly to have no icon for Ansible files.

Before After
image image

Copy link
Contributor

@priyamsahoo priyamsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorchW, thanks for pointing it out. We already have an SVG located at the images dir. Kindly update the PR to use that SVG rather than adding a new PNG.

@GeorchW
Copy link
Contributor Author

GeorchW commented May 6, 2024

We already have an SVG located at the images dir. Kindly update the PR to use that SVG rather than adding a new PNG.

Yes, I used that SVG file and adjusted the margins and the color slightly to fit with the other file icons in VS Code. The original icon is bigger and brighter and thus looks out-of-place. I had a look at it in both dark and light mode, and the adjusted color works for both. (I just had a look at the default dark and light themes, I didn't check every theme there is.)

@GeorchW
Copy link
Contributor Author

GeorchW commented Jul 20, 2024

@priyamsahoo ping

@goneri
Copy link
Contributor

goneri commented Jul 29, 2024

@GeorchW could you please rebase?

@GeorchW
Copy link
Contributor Author

GeorchW commented Jul 30, 2024

@goneri done

@goneri goneri enabled auto-merge (rebase) July 30, 2024 17:54
@goneri
Copy link
Contributor

goneri commented Jul 30, 2024

Thank you @GeorchW!

Copy link

@goneri goneri merged commit 61f0c07 into ansible:main Jul 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants