Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial README for Tests. #1369

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Added initial README for Tests. #1369

merged 2 commits into from
Jun 18, 2024

Conversation

omaciel
Copy link
Contributor

@omaciel omaciel commented Jun 14, 2024

Initial documentation for running automated test suites.

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manstis
Copy link
Contributor

manstis commented Jun 14, 2024

This is what I find hard to understand...

The tests on this PR fail whereas they pass on #1370

@TamiTakamiya @goneri Are tests in this repository notoriously flakey?

@manstis
Copy link
Contributor

manstis commented Jun 14, 2024

@omaciel You need to add a label for the ack / ack / ack action to pass.

(I added "enhancement" for you).

@omaciel
Copy link
Contributor Author

omaciel commented Jun 14, 2024

Thank you @manstis I saw the error but I don't seem to have the right access to add labels :/

Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ganeshrn ganeshrn added the documentation Improvements or additions to documentation label Jun 18, 2024
@ganeshrn ganeshrn added enhancement and removed documentation Improvements or additions to documentation labels Jun 18, 2024
@ganeshrn
Copy link
Member

@omaciel I have added you in the teams/lightspeed-ansible-vscode team, so you should have the required access.

@ganeshrn ganeshrn merged commit 400250a into ansible:main Jun 18, 2024
15 of 17 checks passed
@omaciel
Copy link
Contributor Author

omaciel commented Jun 18, 2024

Thank you @ganeshrn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants