Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creator folder opening #1376

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

priyamsahoo
Copy link
Contributor

@priyamsahoo priyamsahoo commented Jun 18, 2024

Adds the ability to open the workspace folder after scaffolding is done based on the workspace folder count. This resolves the issue of ansible-creator scaffolding not working when used multiple times.
Fixes: #1217.

@omaciel
Copy link
Contributor

omaciel commented Jun 18, 2024

Will there be tests added/updated as part of this PR?

@ganeshrn
Copy link
Member

Will there be tests added/updated as part of this PR?

That's a good catch, the coverage is reduced by 0.2%. @priyamsahoo Can you please add test cases to this PR.

@priyamsahoo
Copy link
Contributor Author

@omaciel, @ganeshrn, as of now, there are no tests for the ansible-creator scaffolding features. I am in the process of adding the tests (One of the PRs in this process is #1318). I should add the tests of all these together in the subsequent PRs.

@omaciel
Copy link
Contributor

omaciel commented Jun 18, 2024

@priyamsahoo I don't want to introduce changes to your existing processes... yet ;) but I think it would give your PR a major boost of confidence if the tests were part of it

@priyamsahoo
Copy link
Contributor Author

In that case, this PR has to wait for a week or two before I set up the testing framework for Ansible content creator web views in the extension (which is currently nonexistent).

@omaciel
Copy link
Contributor

omaciel commented Jun 18, 2024

@priyamsahoo sounds like a great opportunity to handle an existing technical debt then?

@ssbarnea ssbarnea merged commit f0df967 into ansible:main Jun 21, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Scaffolding collection fails when the web view in used for subsequent usage
5 participants