-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action field in Recommendation events have a blank/null value #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06d2b4e
to
af53250
Compare
70fbecf
to
4c31703
Compare
4c31703
to
80dbfe0
Compare
4a2d4cb
to
2c6f60e
Compare
2c6f60e
to
6ed8c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/AAP-24192
Description
The goal is to provide some quick fix some more common use cases, where action feedback is being handled in a wrong way, without a need for a bigger refactoring.
This PR improves the lifecycle of completion / feedback events , by assuming that several completion requests can be sent, before the suggestion is displayed to the user, this way:
HTTP 200
) completion request, it will end up on an action feedback event, can be accepted, rejected or ignoredTested use cases
accept
,acceptKey
) also by using keys (Tab
,Esc
)TODO: Update/add unit tests