Outline should not be updated if it is given in the input to generation API #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
requested review from
audgirka,
alisonlhart,
ganeshrn,
robinbobbitt and
goneri
…f-it-is-given-in-input
goneri
approved these changes
Jun 21, 2024
…f-it-is-given-in-input
TamiTakamiya
deleted the
TamiTakamiya/outline-should-not-be-updated-if-it-is-given-in-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the step 2 of Playbook Generation UI, a user can edit outline as a numbered list. If it is edited, the edited outline is sent to WCA generate playbook API. At that time, we do not need to create outline. However, the current code create outline and update the edited outline with the created outline. This PR is for fixing that behavior.