Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-33750: lightspeed/role: add the role_name field #1612

Merged
merged 2 commits into from
Nov 8, 2024
Merged

AAP-33750: lightspeed/role: add the role_name field #1612

merged 2 commits into from
Nov 8, 2024

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Oct 30, 2024

No description provided.

@goneri goneri requested review from a team as code owners October 30, 2024 13:47
@goneri goneri changed the title lightspeed/role: add the role_name field AAP-33750: lightspeed/role: add the role_name field Oct 30, 2024
@goneri goneri requested a review from TamiTakamiya October 31, 2024 13:05
TamiTakamiya
TamiTakamiya reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@TamiTakamiya TamiTakamiya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question on a duplicated line. I guess it's a typo.

(update) Actually it was NOT a typo.

@goneri goneri enabled auto-merge (rebase) November 7, 2024 15:08
ssbarnea
ssbarnea previously requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to avoid coverage going down.

@ssbarnea ssbarnea marked this pull request as draft November 7, 2024 15:55
auto-merge was automatically disabled November 7, 2024 15:55

Pull request was converted to draft

@ssbarnea
Copy link
Member

ssbarnea commented Nov 7, 2024

Marked it draft because is not passing CI.

@goneri goneri marked this pull request as ready for review November 7, 2024 16:18
@goneri goneri force-pushed the goneri/lightspeed-role-add-the-role_name-field_13238 branch from f05a632 to fd6afde Compare November 8, 2024 14:27
@ssbarnea ssbarnea self-requested a review November 8, 2024 15:43
@goneri goneri force-pushed the goneri/lightspeed-role-add-the-role_name-field_13238 branch from fd6afde to 2000297 Compare November 8, 2024 15:57
@goneri goneri enabled auto-merge (rebase) November 8, 2024 17:10
@goneri goneri merged commit 04e8b48 into ansible:main Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamiTakamiya TamiTakamiya TamiTakamiya approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees
No one assigned
Labels
enhancement
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goneri @ssbarnea @TamiTakamiya