Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework EE volume mount setting so default value will populate #1613

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

alisonlhart
Copy link
Contributor

@alisonlhart alisonlhart commented Oct 31, 2024

This PR reworks the EE volume mount setting so a default value of [] for the volume mounts array is assigned correctly.

Reason for the change:

Our EE volume mount settings didn't set default values of "" to the src, dest, and options fields due to apparent lack of vscode detection for settings default values at that nested depth.

This means the src, dest, and options values were set to their dictionary object values, for example:

          src: {
            default: "",
            description:
              "The name of the local volume or path to be mounted within execution environment.",
          },

The type would be object, and podman would either throw an error or the error would be output into the log (even if the setting was not used at all).

This PR also removes custom error handling so that podman can throw errors more accurately and display them through toast notifications rather than the log. This allows local volume mounts to be used, since there is no longer path detection required.

There is also a change to update the ANSIBLE_ADJACENT_COLLECTIONS__PATH value in ALS tests, since this path was being skipped previously in tests because the path didn't exist.

This also updates the docs generation script for ALS so empty arrays as default settings values aren't skipped.

Fixes #1524.

@alisonlhart alisonlhart added the bug Something isn't working label Oct 31, 2024
@alisonlhart alisonlhart requested review from a team as code owners October 31, 2024 12:25
@alisonlhart alisonlhart force-pushed the fix/ee-volume-mount-type branch from 72686f1 to 9fb3244 Compare October 31, 2024 12:25
@alisonlhart alisonlhart force-pushed the fix/ee-volume-mount-type branch 2 times, most recently from 46552ed to 2fe351c Compare October 31, 2024 12:29
@alisonlhart alisonlhart force-pushed the fix/ee-volume-mount-type branch from 2fe351c to 35d1f97 Compare October 31, 2024 13:03
@alisonlhart alisonlhart force-pushed the fix/ee-volume-mount-type branch from 35d1f97 to 012d363 Compare October 31, 2024 13:09
@alisonlhart alisonlhart force-pushed the fix/ee-volume-mount-type branch 2 times, most recently from 22b4c3c to 30f68d9 Compare October 31, 2024 19:28
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice digging

@alisonlhart alisonlhart merged commit 407d6d1 into ansible:main Nov 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mounting local volume is not working when using Execution Environment
2 participants