-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework EE volume mount setting so default value will populate #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72686f1
to
9fb3244
Compare
46552ed
to
2fe351c
Compare
2fe351c
to
35d1f97
Compare
35d1f97
to
012d363
Compare
22b4c3c
to
30f68d9
Compare
30f68d9
to
5a81011
Compare
cidrblock
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice digging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the EE volume mount setting so a default value of
[]
for the volume mounts array is assigned correctly.Reason for the change:
Our EE volume mount settings didn't set default values of
""
to thesrc
,dest
, andoptions
fields due to apparent lack of vscode detection for settings default values at that nested depth.This means the
src
,dest
, andoptions
values were set to their dictionary object values, for example:The type would be
object
, and podman would either throw an error or the error would be output into the log (even if the setting was not used at all).This PR also removes custom error handling so that podman can throw errors more accurately and display them through toast notifications rather than the log. This allows local volume mounts to be used, since there is no longer path detection required.
There is also a change to update the
ANSIBLE_ADJACENT_COLLECTIONS__PATH
value in ALS tests, since this path was being skipped previously in tests because the path didn't exist.This also updates the docs generation script for ALS so empty arrays as default settings values aren't skipped.
Fixes #1524.