-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace force param with overwrite in creator webviews #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
alisonlhart
approved these changes
Nov 21, 2024
Moving back to draft - there's an issue with versions of creator using |
alisonlhart
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see above comment)
… Versions of ansible-creator
for more information, see https://pre-commit.ci
alisonlhart
approved these changes
Nov 22, 2024
Approved and ready for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA : https://issues.redhat.com/browse/AAP-36015
Replace
force
Parameter withoverwrite
in Webview ExtensionThis PR updates the webview in the
vscode-ansible
extension to replace the deprecatedforce
parameter with theoverwrite
parameter. The changes include:Webview and UI Updates
Replaced
force
Parameter withoverwrite
:Improved UI Tests:
testWebViewElements
function.Backend Updates
Introduced
getCreatorVersion
:ansible-creator
version for reuse ingetCreatorCommand
andrunInitCommand
.Updated Command Logic:
--overwrite
for versions >= 24.10.0 and--force
for older versions.Benefits
ansible-creator
versions.