AAP-37422: Empty line at the top of the file break completion #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the first line of the document is empty, the line is removed from the `documentLines` array because of the early `trim()` call. As a consequence, the `promptLine` value is incorrect and not completion is never triggered. This PR address the problem. See: c5b208d
manstis
reviewed
Dec 13, 2024
goneri
deleted the
goneri/AAP-37422-Empty-line-at-the-top-of-the-file-break-completion_9706
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first line of the document is empty, the line is removed from the
documentLinesarray because of the early
trim()call.As a consequence, the
promptLinevalue is incorrect and not completion is never triggered.This PR address the problem.
See: c5b208d