Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode CI failures: ansible-navigator command not found and remove the toast notification pop up #1746

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

tanwigeetika1618
Copy link
Contributor

@tanwigeetika1618 tanwigeetika1618 commented Dec 30, 2024

Related Jira : https://issues.redhat.com/browse/AAP-38115

Fix CI Failures in VSCode Extension

This PR addresses multiple CI failures encountered after resolving the "JavaScript heap out of memory" error. Below is a summary of the issues identified and the corresponding fixes applied:

1. Ansible-Navigator Not Found in Test Execution Environment

  • Issue: CI tests failed due to the ansible-navigator tool not being available in the test execution environment on GitHub CI.
  • Fix: Updated the ci.yaml file to explicitly install ansible-dev-tools, which includes ansible-navigator.
    This resolved the failures for:
    • "Execute playbook with ansible-navigator EE mode"
    • "Execute playbook without EE mode"
      Both tests successfully picked the correct command and passed.

2. ElementNotInteractableError: Add Plugin Webview Not Rendered Properly

  • Issue: The test for "Test Collection Plugins Scaffolding" failed due to the Add Plugin webview not being rendered properly on Linux. The error ElementNotInteractableError was observed.
  • Fix: Identified and corrected a file mismatch in addPluginPage.ts. The stylesheet was incorrectly referenced as AddPluginPageStyle.ss instead of addPluginPageStyle.css.
    After the correction, the Add Plugin webview rendered correctly, and the test passed.

3. ElementClickInterceptedError: Ansible Playbook Scaffolding

  • Issue: During the "Ansible Playbook Scaffolding" test, the error ElementClickInterceptedError was encountered. This occurred because a notification popup (toast box) intercepted clicks on the webview iframe.
  • Fix: Removed the toast notification popup code from createAnsibleProjectPage.ts.
    This resolved the issue, allowing the test to execute successfully.

Summary

The fixes outlined above have addressed all the identified CI failures, ensuring successful test execution across all scenarios.
This PR improves the robustness of the test suite and increases project coverage by 4.92%.

@tanwigeetika1618 tanwigeetika1618 changed the title Update description message in contentCreatorUiTest.ts file Fix vscode CI failures: ansible-navigator command not found and remove the toast notification pop up Jan 8, 2025
@alisonlhart alisonlhart marked this pull request as ready for review January 8, 2025 13:15
@alisonlhart alisonlhart requested review from a team as code owners January 8, 2025 13:15
Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - overriding the codecov failure, as we have a ticket for researching codecov issues in our backlog and merging this PR will resolve test failures in the pipeline. Note that the "project" coverage went up by 4% while patch was at 0%, which points to the overall codecov issue we've been seeing.

Copy link
Contributor

@abhikdps abhikdps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tanwigeetika1618
Copy link
Contributor Author

Codecov patch is failing unexpectedly. These changes are covered by the UI test: "Test collection plugins scaffolding". The lines changed should be showing as covered.

The relevant tests succeeded:

  Test collection plugins scaffolding
locator=By(xpath, //vscode-text-field[@id='path-url']) found in iframe 301114ee-10cd-4f50-9f96-ba884da51390!
    ✔ Check add-plugin webview elements

Overriding codecov for this reason. This is a false positive.

@alisonlhart alisonlhart merged commit 1bcd7c5 into ansible:main Jan 8, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants