-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vscode CI failures: ansible-navigator command not found and remove the toast notification pop up #1746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving - overriding the codecov failure, as we have a ticket for researching codecov issues in our backlog and merging this PR will resolve test failures in the pipeline. Note that the "project" coverage went up by 4% while patch was at 0%, which points to the overall codecov issue we've been seeing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Codecov patch is failing unexpectedly. These changes are covered by the UI test: "Test collection plugins scaffolding". The lines changed should be showing as covered. The relevant tests succeeded:
Overriding codecov for this reason. This is a false positive. |
Related Jira : https://issues.redhat.com/browse/AAP-38115
Fix CI Failures in VSCode Extension
This PR addresses multiple CI failures encountered after resolving the "JavaScript heap out of memory" error. Below is a summary of the issues identified and the corresponding fixes applied:
1. Ansible-Navigator Not Found in Test Execution Environment
ansible-navigator
tool not being available in the test execution environment on GitHub CI.ci.yaml
file to explicitly installansible-dev-tools
, which includesansible-navigator
.This resolved the failures for:
Both tests successfully picked the correct command and passed.
2. ElementNotInteractableError: Add Plugin Webview Not Rendered Properly
Add Plugin
webview not being rendered properly on Linux. The errorElementNotInteractableError
was observed.addPluginPage.ts
. The stylesheet was incorrectly referenced asAddPluginPageStyle.ss
instead ofaddPluginPageStyle.css
.After the correction, the
Add Plugin
webview rendered correctly, and the test passed.3. ElementClickInterceptedError: Ansible Playbook Scaffolding
ElementClickInterceptedError
was encountered. This occurred because a notification popup (toast box) intercepted clicks on the webview iframe.createAnsibleProjectPage.ts
.This resolved the issue, allowing the test to execute successfully.
Summary
The fixes outlined above have addressed all the identified CI failures, ensuring successful test execution across all scenarios.
This PR improves the robustness of the test suite and increases project coverage by 4.92%.