Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset all views when fromjson #3346

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: reset all views when fromjson #3346

merged 1 commit into from
Mar 6, 2023

Conversation

NewByVector
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. pkg:x6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Mar 6, 2023

@NewByVector Please provide us with more info about this pull request.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #3346 (473789d) into master (3bb76ed) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3346   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files         274      274           
  Lines       16352    16352           
  Branches     3855     3855           
=======================================
  Hits         4435     4435           
  Misses      11540    11540           
  Partials      377      377           
Flag Coverage Δ
x6 10.42% <0.00%> (ø)
x6-common 62.24% <ø> (ø)
x6-geometry 50.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/renderer/scheduler.ts 4.61% <0.00%> (ø)

@NewByVector NewByVector merged commit 1de8ebe into master Mar 6, 2023
@NewByVector NewByVector deleted the dev.v branch March 6, 2023 03:35
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant