Add new API for extracting the underling CBOR value from a CBORValidator for reuse #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure what's up with WASM tests. |
anweiss
force-pushed
the
216-extract-value
branch
2 times, most recently
from
e796d1c to
4ca8e57
Compare
anweiss
force-pushed
the
216-extract-value
branch
from
4ca8e57 to
0408b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
This reduces the time for
pycddlto do validation+deserialization combo for a small document from 2.5µs to 1.8µs, by allowing only a single CBOR parse.Happy to do a different API variation if you prefer.