-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prioritization_fee.rs #3235
Conversation
are the other methods used? if the compute unit price isn't used then I feel this trait is useless and we should remove the whole thing. |
Agree, it's the time to refactor out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me - thanks for cleaning it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update title of the PR and add a basic description to the PR
aa64bd1
to
230e6b3
Compare
91b1ab0
to
a835a96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The prioritization_fee.rs had only one relevant calculation of
prioritization fee that was used by ComputeBudgetLimits. This patch moves the calculation to get_prioritization_fee and removes prioritization_fee.rs altogether.