agave-validator: add args tests for repair-shred-from-peer #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
add-args-test-for-repair-shred-from-peer
branch
from
ff93c2c to
31c39f8
Compare
| let shred_index = value_t_or_exit!(matches, "shred", u64); | ||
| let repair_shred_from_peer_args = RepairShredFromPeerArgs::from_clap_arg_match(matches); | ||
| if repair_shred_from_peer_args.slot.is_none() { | ||
| eprintln!("slot is required"); |
There was a problem hiding this comment.
if these are required, why are they specified as optional in struct itself? seems like we should make invalid argument combinations unrepresentable, this way all the validation can be delegated to clap once we upgrade to v4.
|
|
||
| #[derive(Debug, PartialEq, Eq)] | ||
| pub struct RepairShredFromPeerArgs { | ||
| pub pubkey: Option<Pubkey>, |
There was a problem hiding this comment.
these should not be options since theyvare required args
alexpyattaev
requested changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4082
Summary of Changes
value_t_or_exit !with other functions and moved the exit logic to thefn execute