Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply PR#31: optimize retry pool #5113

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KirillLykov
Copy link

Problem

Transactions not included in the retry pool on full utilization

This PRs adds back #31

Summary of Changes

  • do not insert transactions with zero max_retries to the retry pool
  • remove transactions reached max_retries in the same iteration of the loop
  • dynamically select sleep time between iterations based on last_sent_time in TransactionInfo

@KirillLykov KirillLykov requested a review from fanatid March 2, 2025 19:28
@KirillLykov KirillLykov added the v2.2 Backport to v2.2 branch label Mar 3, 2025
Copy link

mergify bot commented Mar 3, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant