build: migrate to nimbus and fix build #319

kristw · 2020-01-30T09:44:49Z

🏠 Internal

Migrate build tools from beemo to nimbus
Fix issues
- Move buildAssets.js under scripts
- Replace eslint rule sort-keys with jsx-sort-default-props and sort-prop-types
- Remove unnecessary eslint-disable
- Replace if (x.length) with if (x.length > 0)
- Switch for loop to use .forEach when possible
- Change module.exports to export default (for parallel coordinates)
- Fix other lint errors

Tested by manually going through all examples in storybook and verify them against master.

@etr2460 @rusackas

netlify · 2020-01-31T19:58:47Z

Deploy preview for superset-ui-plugins ready!

Built with commit 8eedc66

https://deploy-preview-319--superset-ui-plugins.netlify.com

codecov · 2020-01-31T19:58:52Z

Codecov Report

❗ No coverage uploaded for pull request base (master@b9f0e62). Click here to learn what that means.
The diff coverage is 7.69%.

@@           Coverage Diff            @@
##             master    #319   +/-   ##
========================================
  Coverage          ?   1.48%           
========================================
  Files             ?     186           
  Lines             ?    5797           
  Branches          ?     339           
========================================
  Hits              ?      86           
  Misses            ?    5699           
  Partials          ?      12

Impacted Files	Coverage Δ
...i-legacy-plugin-chart-horizon/src/HorizonChart.jsx	`0% <ø> (ø)`
...superset-ui-legacy-plugin-chart-chord/src/Chord.js	`0% <ø> (ø)`
...-legacy-plugin-chart-treemap/src/transformProps.js	`0% <ø> (ø)`
...et-ui-preset-chart-xy/src/encodeable/types/Axis.ts	`0% <ø> (ø)`
...i-plugin-chart-icicle-event/src/IcicleEventViz.tsx	`0% <ø> (ø)`
...erset-ui-legacy-preset-chart-nvd3/src/PropTypes.js	`0% <ø> (ø)`
...-preset-chart-xy/src/Line/legacy/transformProps.ts	`0% <ø> (ø)`
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx	`0% <ø> (ø)`
...y-plugin-chart-force-directed/src/ForceDirected.js	`0% <ø> (ø)`
...rset-ui-preset-chart-xy/src/Line/transformProps.ts	`0% <ø> (ø)`
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f0e62...8eedc66. Read the comment docs.

kristw · 2020-02-01T05:21:30Z

Ready for review

package.json

Co-Authored-By: Evan Rusackas <[email protected]>

package.json

packages/superset-ui-legacy-plugin-chart-heatmap/src/Heatmap.css

packages/superset-ui-legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx

packages/superset-ui-legacy-plugin-chart-map-box/src/utils/geo.js

packages/superset-ui-legacy-plugin-chart-markup/src/Markup.css

...s/superset-ui-legacy-plugin-chart-parallel-coordinates/src/vendor/parcoords/d3.parcoords.css

packages/superset-ui-legacy-plugin-chart-sunburst/src/Sunburst.js

packages/superset-ui-legacy-plugin-chart-sunburst/src/utils/wrapSvgText.js

packages/superset-ui-legacy-preset-chart-nvd3/src/utils/isTruthy.js

packages/superset-ui-legacy-preset-chart-nvd3/test/utils.test.js

packages/superset-ui-plugin-chart-icicle-event/src/IcicleEventChart.tsx

packages/superset-ui-plugin-chart-icicle-event/src/utils/IcicleEventTreeHelpers.ts

packages/superset-ui-plugin-chart-table/src/components/HTMLRenderer.tsx

rusackas

LGTM, but I've peppered the thread with little comments and questions about various nits in case you think any are worth addressing. Love all the cleanup work you've done in here, and it's nice to see newer ES features coming in to play!

…ui-plugins into kristw--nimbus

* build: change gitignore and update package.json * fix: importing issues * fix: missing reference * build: move buildAssets script * fix: prettier * fix: lints jsx-sort-default-props, sort-prop-types * fix: more lints jsx-sort-default-props, sort-prop-types * fix: remove all unnecessary eslint-disable * fix: export default type * fix: use .forEach instead of for...of * fix: package.json * fix: ts issue * fix: webpack config * fix: issue with for loop * fix: parallel coordinates * fix: parallel coordinates * fix: add prettier check Co-Authored-By: Evan Rusackas <[email protected]> * build: change type:dts to type * fix: bring back Math.pow * fix: use optional * fix: bring back .0 * fix: declare word in the loop * fix: for loop in sunburst Co-authored-by: Evan Rusackas <[email protected]>

kristw added 3 commits January 30, 2020 01:37

build: change gitignore and update package.json

b9f0e62

fix: importing issues

827a271

fix: missing reference

8dbdf39

kristw requested a review from a team as a code owner January 30, 2020 09:44

pull-request-size bot added the size/L label Jan 30, 2020

kristw added 9 commits January 30, 2020 01:46

build: move buildAssets script

ab49024

fix: prettier

7eb7a7c

fix: lints jsx-sort-default-props, sort-prop-types

655cd8a

fix: more lints jsx-sort-default-props, sort-prop-types

63da88b

fix: remove all unnecessary eslint-disable

52ec8b7

fix: export default type

fe4bc50

fix: use .forEach instead of for...of

723507a

fix: package.json

6bceb12

fix: ts issue

6edf26f

kristw added 2 commits January 31, 2020 14:13

fix: webpack config

f29ca01

fix: issue with for loop

0f1a640

pull-request-size bot added size/XXL and removed size/L labels Jan 31, 2020

kristw added 2 commits January 31, 2020 16:57

fix: parallel coordinates

5bd4089

fix: parallel coordinates

5cdb780

kristw added the reviewable label Feb 1, 2020

kristw assigned kristw and unassigned kristw Feb 1, 2020

trepmag mentioned this pull request Feb 3, 2020

Yarn build fail with The "to" argument must be of type string. Received type object #313

Closed