Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in unit tests #1269

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in unit tests #1269

merged 2 commits into from
Dec 18, 2024

Conversation

AlexejTimonin
Copy link
Contributor

@AlexejTimonin AlexejTimonin commented Jul 23, 2024 •
edited
Loading

PolicyEntry.setInactiveTimoutBeforeGC(long inactiveTimoutBeforeGC) is deprecated, and the deprecation note suggests using PolicyEntry.setInactiveTimeoutBeforeGC(long setInactiveTimeoutBeforeGC).

The deprecation note has a typo, it says to use the getInactiveTimeoutBeforeGC for the deprecated setInactiveTimoutBeforeGC, but should be setInactiveTimeoutBeforeGC

@AlexejTimonin AlexejTimonin changed the title Code Janitor task: Replace use of deprecated setInactiveTimoutBeforeGC in unit tests [AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in unit tests Jul 27, 2024
cshannon
cshannon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@cshannon cshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review (I'm going back now through some of the older PRs and noticed this), this LGTM, thanks for the code cleanup!

@cshannon cshannon merged commit cb52807 into apache:main Dec 18, 2024
1 check failed
cshannon pushed a commit that referenced this pull request Dec 18, 2024
@AlexejTimonin @cshannon
[AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in uni…
15106cb 
…t tests (#1269)

* Fix typo in the deprication doc

* Replace use of depricated setInactiveTimoutBeforeGC

(cherry picked from commit cb52807)
cshannon pushed a commit that referenced this pull request Dec 18, 2024
@AlexejTimonin @cshannon
[AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in uni…
757616e 
…t tests (#1269)

* Fix typo in the deprication doc

* Replace use of depricated setInactiveTimoutBeforeGC

(cherry picked from commit cb52807)
cesarhernandezgt pushed a commit to cesarhernandezgt/activemq that referenced this pull request Jan 16, 2025
@AlexejTimonin @cesarhernandezgt
[AMQ-9543] Replace use of deprecated setInactiveTimoutBeforeGC in uni…
d6416a0 
…t tests (apache#1269)

* Fix typo in the deprication doc

* Replace use of depricated setInactiveTimoutBeforeGC

(cherry picked from commit cb52807)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cshannon cshannon cshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexejTimonin @cshannon