-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMBARI-26113: Switch the PhantomJS used by Karma tests to chromium-browser #3809
Conversation
cc @JiaLiangC |
Have you tried, for example: Puppeteer ? |
No, just switched the test browser. |
Recommended Node.js Versions: karma-chrome-launcher 3.2.0 works well with Node.js versions from 12.x to 16.x. These versions are also commonly supported by many other dependencies in the JavaScript ecosystem. |
@zRains Yes I know about it, I make rpm ambari under rocky 9 on docker. Without tests rpm is created. When I run tests it doesn't work and I can't find the reason. |
@mgucma Try running the test command in the same environment without using Docker; you should be able to get error messages, or use the -X parameter. |
@zRains My Pull Requet to Rocky 9 will not pass, but I need Ambari update for this system. I need to do migration from Centos 7 to Rocky 9. Can you show me the way to make corrections? |
The support for other big data components on Rocky 9 is controlled by the Apache Bigtop project. Additionally, I recommend that you first submit your code as a PR, so that some initial review and suggestions can be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your great work! |
What changes were proposed in this pull request?
With the arrival of the
ambari-web
upgrade PR: #3770 ,PhantomJS
is no longer sufficient to support future testing tasks, as its support for ES5 has been abandoned(#14506, #14458). Thechromium-browser
will provide ES5 syntax support and enable testing for more libraries. This will be one of the foundational steps in the overallambari-web
upgrade plan.This PR will be divided into two modules:
ambari-web
andambari-admin
. PhantomJS will be completely removed, and some failing tests will be fixed.How was this patch tested?
Ambari-web

Ambari-admin
