New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint CI #15

Closed

kou opened this issue Aug 29, 2024 · 0 comments · Fixed by #92

Milestone

Member

kou commented Aug 29, 2024

We want to use pre-commit based lint system.

Related parts:

kou added a commit to kou/arrow-go that referenced this issue


          apacheGH-15: Enable linter

887f621

Fix apacheGH-15

Related parts:
* https://github.com/apache/arrow/blob/58415d1fac50cb829b3dcf08526033d6db8c30db/.pre-commit-config.yaml#L151-L164
* https://github.com/apache/arrow/blob/main/.golangci.yaml

staticcheck is also used via golangci. We need to use
"nolint:staticcheck,XXX" instead of "lint:ignore XXX" for it.

See also: https://golangci-lint.run/usage/false-positives/#nolint

kou mentioned this issue

GH-15: Enable linter #92

Merged

kou added a commit to kou/arrow-go that referenced this issue


          apacheGH-15: Enable linter

0e85902

Fix apacheGH-15

Related parts:
* https://github.com/apache/arrow/blob/58415d1fac50cb829b3dcf08526033d6db8c30db/.pre-commit-config.yaml#L151-L164
* https://github.com/apache/arrow/blob/main/.golangci.yaml

staticcheck is also used via golangci. We need to use
"nolint:staticcheck,XXX" instead of "lint:ignore XXX" for it.

See also: https://golangci-lint.run/usage/false-positives/#nolint

kou closed this as completed in #92

kou closed this as completed in

7550e50

zeroshade added this to the 18.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment