-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use octokit to add assignee #6267
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
|
||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
import { Octokit } from "@octokit/action"; | ||
|
||
const [owner, repo] = process.env.GITHUB_REPOSITORY.split("/"); | ||
|
||
new Octokit().rest.issues.addAssignees({ | ||
owner, | ||
repo, | ||
issue_number: process.env.ISSUE_NUMBER, | ||
assignees: [process.env.ASSIGNEE], | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,17 +25,16 @@ permissions: | |
|
||
jobs: | ||
issue_assign: | ||
runs-on: ubuntu-latest | ||
if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' | ||
concurrency: | ||
group: ${{ github.actor }}-issue-assign | ||
runs-on: ubuntu-latest | ||
steps: | ||
- run: | | ||
CODE=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -LI https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees/${{ github.event.comment.user.login }} -o /dev/null -w '%{http_code}\n' -s) | ||
if [ "$CODE" -eq "204" ] | ||
then | ||
echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" | ||
curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -d '{"assignees": ["${{ github.event.comment.user.login }}"]}' https://api.github.com/repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/assignees | ||
else | ||
echo "Cannot assign issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" | ||
fi | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 20 | ||
- run: npm install @octokit/action | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Compared to having our own implemented What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds like a good idea to me -- perhaps we can improve it in a follow on PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to me. This PR itself is good enough to merge. I can help improve it later. |
||
- run: node .github/actions/assign.mjs | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
ISSUE_NUMBER: ${{ github.event.issue.number }} | ||
ASSIGNEE: ${{ github.event.comment.user.login }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can add some comments here explaining what this does?