Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-18322: [Python] Add PYARROW_WITH_FLIGHT to PyArrow C++ cmake (#…
…14642) This PR adds the use of `PYARROW_WITH_FLIGHT` environment variable when building PyArrow C++. With this change PyArrow will be able to build successfully even when Arrow C++ is installed without Arrow Flight ([example](https://github.com/OSGeo/gdal/blob/58ab718542a7b5ceb94e3f24a5acc0b18ac1efb2/docker/ubuntu-full/Dockerfile#L223-L231), JFrog artifactory) but `ARROW_FLIGHT` flag is not registered to be set to off. Note: `PYARROW_WITH_FLIGHT=0` is needed when building PyArrow. I tested the change on my regular build with Arrow Flight but with removed `libarrow_flight*` libs. Without this patch I get: ``` CMake Error at /Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightTargets.cmake:93 (message): The imported target "ArrowFlight::arrow_flight_shared" references the file "/Users/alenkafrim/repos/arrow/dist/lib/libarrow_flight.1100.0.0.dylib" but this file does not exist. Possible reasons include: * The file was deleted, renamed, or moved to another location. * An install or uninstall procedure did not complete successfully. * The installation package was faulty and contained "/Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightTargets.cmake" but not all the files it references. Call Stack (most recent call first): /Users/alenkafrim/repos/arrow/dist/lib/cmake/ArrowFlight/ArrowFlightConfig.cmake:56 (include) CMakeLists.txt:262 (find_package) ``` With this patch PyArrow builds succesfully. Authored-by: Alenka Frim <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
- Loading branch information