Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Remove usage of cpp11's HAS_UNWIND_PROTECT #44924

Closed
Tracked by #412
DavisVaughan opened this issue Dec 3, 2024 · 3 comments
Closed
Tracked by #412

[R] Remove usage of cpp11's HAS_UNWIND_PROTECT #44924

DavisVaughan opened this issue Dec 3, 2024 · 3 comments
Assignees
@assignUser
Labels
Component: R Type: enhancement
Milestone
20.0.0

Comments

@DavisVaughan
Copy link
Contributor

Describe the enhancement requested

cpp11 is bumping to require R >=4.0.0 in the next release r-lib/cpp11#411

That means that R_UnwindProtect() is always available, and the macro HAS_UNWIND_PROTECT is no longer needed. I'm going to keep it around for a release or two, but if you could remove your reliance on it, then that'd be great!

arrow/r/src/safe-call-into-r-impl.cpp

Line 49 in 50f2d6e

#if defined(HAS_UNWIND_PROTECT)

Component(s)

R
@DavisVaughan DavisVaughan mentioned this issue Dec 3, 2024
Open
2 tasks
@assignUser
Copy link
Member

Thanks for the early warning, should be easy enough to remove.

We just finished a release so the change will only hit CRAN after the next release, so probably February, is that ok?

@DavisVaughan
Copy link
Contributor Author

Sure, no big rush on my end!

@assignUser assignUser self-assigned this Dec 3, 2024
@github-actions github-actions bot mentioned this issue Jan 14, 2025
Merged
assignUser added a commit that referenced this issue Feb 19, 2025
@assignUser
GH-44924: [R] Remove usage of cpp11's HAS_UNWIND_PROTECT (#45261)
7167ed1 
### Rationale for this change

The macro is no longer required on R >= 4.0 which is our minimum version.

### What changes are included in this PR?

Remove use of HAS_UNWIND_PROTECT

### Are these changes tested?

ci
### Are there any user-facing changes?

no
* GitHub Issue: #44924

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
@assignUser assignUser added this to the 20.0.0 milestone Feb 19, 2025
@assignUser
Copy link
Member

Issue resolved by pull request 45261
#45261

kou pushed a commit to kou/arrow that referenced this issue Feb 25, 2025
@assignUser @kou
apacheGH-44924: [R] Remove usage of cpp11's HAS_UNWIND_PROTECT (apach…
174db12 
…e#45261)

### Rationale for this change

The macro is no longer required on R >= 4.0 which is our minimum version.

### What changes are included in this PR?

Remove use of HAS_UNWIND_PROTECT

### Are these changes tested?

ci
### Are there any user-facing changes?

no
* GitHub Issue: apache#44924

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@assignUser @DavisVaughan