Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11822: [Rust][Datafusion] Support case sensitive for function #9600
ARROW-11822: [Rust][Datafusion] Support case sensitive for function #9600
Changes from 34 commits
e45e355
fadef3f
97fb5cd
122ab74
6793160
33a1a9e
33a1b95
ea8ca2a
a2e5eac
f897970
b135fe8
2092439
fb1a41d
474cb61
b2e49cf
af1568f
8fa5b29
8902378
6578bfb
7fe6ae8
72fb896
edfcdb7
bb10ef3
2025c02
09926df
49c1029
942cad6
fc88704
6cd8519
edff233
dba97ca
2bc66d6
8c8fa50
ca63ae9
f09f10d
acf2c0d
53d3492
910aba4
93f57de
4624955
cd336f1
c8608dd
167e501
c12c243
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I looked through the diff and I couldn't figure out what
input_name
is actually used for. Is this new field needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mainly used to display the name of the function entered by the user.
md5 (Utf8("a")) instead of mD5(Utf8("a")) if there is no input_name.
For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW here is what postgres does for the same query (uses the lowercase, canonical function name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i fix it, use the lowercase in postgress. I add a enum with two feild, one is LikeMySQL, another is LikePostgreSQL.