-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reolling forward property-based tests for coders #23425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23425 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 718 718
Lines 95680 95680
=======================================
+ Hits 70262 70263 +1
+ Misses 24107 24106 -1
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
st.booleans())) | ||
|
||
FORBIDDEN_FIELD_NAMES = { | ||
'as', 'for', 'in', 'with', 'or', 'is', 'not', 'if', 'elif', 'else' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
These are all python keywords but not all Python keywords. Is there any source why these names are fobidden, or there is a list of forbidden field names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Yi! Great observation. I've added a keyword check instead, which is the same one used when building namedtuples, which is what row coders use underneath.
FYI as a plane ride project I started looking at using a recursive rule to generate Beam schemas: #23361 You may be interested in the Also, it would be great to combine these two efforts (first generate a schema, then generate test data given a schema) down the road! |
I created #23436 to track switching over - could we move forward with this for now? : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM!
Yep! Sorry I didn't mean to hold this up. |
Assigning reviewers. If you would like to opt out of this review, comment R: @yeandy for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
I've tested these several times, to make sure that the test will remain consistently passing.
r: @Abacn
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.