-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-testing #889
Merged
Merged
release-testing #889
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
533f165
make script shebangs more flexible
Michael-J-Ward 2c04ae2
move location of python tests
Michael-J-Ward 5e048b0
add documentation for testing against release candidate
Michael-J-Ward 51cd808
add dev script for cleaning maturin build artifacts
Michael-J-Ward ca8834d
update ruff lint config for new test location
Michael-J-Ward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
#!/usr/bin/env bash | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# | ||
|
||
# This cleans up the project by removing build artifacts and other generated files. | ||
|
||
# Function to remove a directory and print the action | ||
remove_dir() { | ||
if [ -d "$1" ]; then | ||
echo "Removing directory: $1" | ||
rm -rf "$1" | ||
fi | ||
} | ||
|
||
# Function to remove a file and print the action | ||
remove_file() { | ||
if [ -f "$1" ]; then | ||
echo "Removing file: $1" | ||
rm -f "$1" | ||
fi | ||
} | ||
|
||
# Remove .pytest_cache directory | ||
remove_dir .pytest_cache/ | ||
|
||
# Remove target directory | ||
remove_dir target/ | ||
|
||
# Remove any __pycache__ directories | ||
find python/ -type d -name "__pycache__" -print | while read -r dir; do | ||
remove_dir "$dir" | ||
done | ||
|
||
# Remove pytest-coverage.lcov file | ||
# remove_file .coverage | ||
# remove_file pytest-coverage.lcov | ||
|
||
# Remove rust-coverage.lcov file | ||
# remove_file rust-coverage.lcov | ||
|
||
# Remove pyo3 files | ||
find python/ -type f -name '_internal.*.so' -print | while read -r file; do | ||
remove_file "$file" | ||
done | ||
|
||
echo "Cleanup complete." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've always seen the former approach of
#!/bin/bash
. For my own edification, why this change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mental model for
env
is basically "search $PATH for this executable and use it".The pattern is more commonly used for things like python, i.e.
#!/usr/bin/env python
because then the script will automatically use whatever virtual environment you have activated.It's less commonly used for
bash
, but I use a pretty niche operating system (NixOS) which doesn't use/bin/bash
.