Add some zero column tests covering LIMIT, GROUP BY, WHERE, JOIN, and WINDOW #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Thank you @Kev1n8 🙏
FYI @kazuyukitanimura as the original filer of #5713
alamb
approved these changes
Jul 24, 2024
| @@ -1225,6 +1225,63 @@ statement ok | |||
| SELECT * EXCEPT(a, b, c, d) | |||
| FROM table1 | |||
|
|
|||
| # try zero column with LIMIT, 1 row but empty | |||
| statement ok | |||
There was a problem hiding this comment.
I had these tests checked out locally to double check they actually did produce no columns but a single row and by using query rather than statement
Thing looks great to me, so I pushed a commit to this branch to update the tests
There was a problem hiding this comment.
🤔 that seems to cause errors on mac, so I reverted the change
|
I also updated the description to say this PR closes #5713, unless there is additional work we know about |
This reverts commit fd381fc.
|
Thanks for reviewing :) |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes: #5713.
Rationale for this change
To make sure there are not any other execs having issues when it comes to zero-column batches.
What changes are included in this PR?
I added some tests to sqllogictest to see if statements work with no column when using LIMIT, GROUP BY, WHERE JOIN and WINDOW. Please let me know if there's anything to improve or wrong.
Are these changes tested?
PASSed the sqllogictests.
Are there any user-facing changes?