Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure most of links in docs are correct #1808

Merged

Conversation

HaoYang670
Copy link
Contributor

Which issue does this PR close?

Re #1741. I think we can only partially close it now. Because there are still some unsolved links in the docs (such as private struct and private functions)

Rationale for this change

run

cargo doc --document-private-items --no-deps --workspace 

and fix the warning.

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
@github-actions github-actions bot added datafusion Changes in the datafusion crate sql SQL Planner labels Feb 11, 2022
@HaoYang670
Copy link
Contributor Author

There are still 7 warnings when running cargo doc. However, I could not find a good solution in a short time. Need your help!

@alamb
Copy link
Contributor

alamb commented Feb 11, 2022

Thanks @HaoYang670 -- I'll try and help sort out the nastier problems later today

@alamb alamb merged commit 4cc8e44 into apache:master Feb 11, 2022
@HaoYang670 HaoYang670 deleted the issue1741_ensure_links_in_docs_correct branch February 11, 2022 13:41
@alamb alamb mentioned this pull request Feb 11, 2022
@alamb
Copy link
Contributor

alamb commented Feb 11, 2022

I took a crack at the last warnings here: #1811

@matthewmturner
Copy link
Contributor

thx @HaoYang670 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants