add fixme-s

apache · Feb 27, 2025 · 6eaaa4d · 6eaaa4d
1 parent d47681f
commit 6eaaa4d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/processing/src/main/java/org/apache/druid/query/JoinDataSource.java b/processing/src/main/java/org/apache/druid/query/JoinDataSource.java
@@ -276,7 +276,9 @@ public boolean isGlobal()
   @Override
   public boolean isProcessable()
   {
-    return left.isProcessable() && right.isGlobal();
+    // FIXME: shouldn't this be?
+    //return left.isProcessable() && right.isGlobal();
+    return false;
   }
 
   /**

diff --git a/processing/src/main/java/org/apache/druid/query/QueryDataSource.java b/processing/src/main/java/org/apache/druid/query/QueryDataSource.java
@@ -97,6 +97,7 @@ public boolean isCacheable(boolean isBroker)
   @Override
   public boolean isGlobal()
   {
+    // FIXME: this feels like dodgy to me - but this is how it was before
     return query.getDataSource().isGlobal();
   }
 

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/external/ExternalDataSource.java b/sql/src/main/java/org/apache/druid/sql/calcite/external/ExternalDataSource.java
@@ -119,6 +119,7 @@ public boolean isGlobal()
   @Override
   public boolean isProcessable()
   {
+    // FIXME this seems illogical
     return false;
   }