Update deprecated com.google.common.io.Files#write #17761
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test failure seems irrelevant to PR. Test unrelated to changes. Ran test locally, and it is able to pass all 12 tests.
|
|
@GWphua , there are some merge conflicts now. Please take a look. |
FrankChen021
added
Area - Dev
|
@kfaraz thanks for the update. I have resolved the merge conflicts, and the previously failing unit test has succeeded. Would you like to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initiated by @kfaraz #17742 (comment)
Replace all deprecated write uses
Added a forbidden-apis entry for com.google.common.io.Files#write
Key changed/added classes in this PR
druid-forbidden-apisThis PR has: