-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cpu 100% in session.handleLoop #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this PR really fix cpu 100% issue? |
Yes, it is for cpu 100% bug fix. The session.handleLoop will run very quickly when the ss.Done is closed but the done select branch can not block when the handlePackage has not exited. And panty add the session.rDone to let the session.handleLoop for-select-done branch block on '<-session.rDone'. the " |
LGTM |
1 similar comment
LGTM |
No description provided.