fix: fix consulRegister not unregister when destory bug #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceLiZhixin
changed the title
AlexStocks
approved these changes
Oct 10, 2020
zouyx
reviewed
Oct 10, 2020
| @@ -187,5 +187,10 @@ func (r *consulRegistry) IsAvailable() bool { | |||
|
|
|||
| // Destroy consul registry center | |||
| func (r *consulRegistry) Destroy() { | |||
| if r.URL != nil{ | |||
There was a problem hiding this comment.
You should change test case for ensure this code become effective
zouyx
reviewed
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
修复consul Registry 在interrupt后不会立刻从注册中心消失的bug
Which issue(s) this PR fixes:
Fixes #749
Special notes for your reviewer:
修复consul Registry 在interrupt后不会立刻从注册中心消失的bug，在consulRegistry的Destory函数中增加对Unregister函数的调用。从而从注册中心反注册。
Does this PR introduce a user-facing change?:
NONE