Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe we can remove null judge in this case #6321

Merged
merged 2 commits into from
Jun 16, 2020
Merged

maybe we can remove null judge in this case #6321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8913f57
update
nineyang Jun 15, 2020
72e5eb8
update
nineyang Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dubbo-common/src/main/java/org/apache/dubbo/common/extension/support/ActivateComparator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,8 @@ public int compare(Object o1, Object o2) {
}
}
}
int n1 = a1 == null ? 0 : a1.order;
int n2 = a2 == null ? 0 : a2.order;
// never return 0 even if n1 equals n2, otherwise, o1 and o2 will override each other in collection like HashSet
return n1 > n2 ? 1 : -1;
return a1.order > a2.order ? 1 : -1;
}

private Class<?> findSpi(Class clazz) {
Expand Down